New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfurling: store favicon and image as Asset on Unfurl and upload to S3 CORE-9302 #14540

merged 34 commits into from Nov 1, 2018


None yet
2 participants

mmaxim commented Nov 1, 2018

Patch does the following:

1.) Introduces Packager whose responsibility is to gather assets needed for displaying an unfurl and turn then into chat1.Asset.
2.) Run PreprocessAsset on the image and favicon from a URL to make sure they are a sane size, and to get meta information.
3.) Uploads the assets using attachments.Store.

@mmaxim mmaxim requested a review from joshblum Nov 1, 2018

mmaxim added some commits Nov 1, 2018


lgtm with the ContentLength tweak

Show resolved Hide resolved go/chat/unfurl/packager.go
Show resolved Hide resolved go/chat/unfurl/packager.go

mmaxim added some commits Nov 1, 2018


@mmaxim mmaxim merged commit 35eab5c into master Nov 1, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/jenkins/pr-head This commit looks good

@mmaxim mmaxim deleted the mike/CORE-9302 branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment