New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unfurling: extract URLs and classify action against settings CORE-9245 #14569

Merged
merged 24 commits into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@mmaxim
Member

mmaxim commented Nov 3, 2018

Patch does the following:

1.) Introduce a new class Extractor which is responsible for extracting URLs from messages, and classifying action to take upon them.
2.) Vendor in github.com/mvdan/xurls in order to harvest the URLs from the message. Use "strict" mode, since this appears to be what every other messenger does.
3.) Use Settings to determine whether or not we should return an UNFURL or PROMPT response for each URL found.

@mmaxim mmaxim requested a review from joshblum Nov 3, 2018

mmaxim added some commits Nov 3, 2018

d
ugh

@mmaxim mmaxim merged commit 961376a into master Nov 5, 2018

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/CORE-9245 branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment