New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont amplify filtered convID list #14575

merged 2 commits into from Nov 5, 2018


None yet
2 participants

mmaxim commented Nov 5, 2018

@mmaxim mmaxim requested a review from joshblum Nov 5, 2018


why not convert query.ConvIDs to a map in the beginning of the loop to optimize the lookup here:

could also continue instead of ok = false and then find the number of filtered with len(rcs) - len(res) but probably less of a perf concern


This comment has been minimized.


mmaxim commented Nov 5, 2018

Ok sure, I'll make that change


@mmaxim mmaxim merged commit 4bc854b into master Nov 5, 2018

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit is being built
ci/circleci Your tests passed on CircleCI!

@mmaxim mmaxim deleted the mike/inboxsigh branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment