New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont amplify filtered convID list #14575

Merged
merged 2 commits into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@mmaxim
Member

mmaxim commented Nov 5, 2018

@mmaxim mmaxim requested a review from joshblum Nov 5, 2018

@joshblum

why not convert query.ConvIDs to a map in the beginning of the loop to optimize the lookup here: https://github.com/keybase/client/pull/14575/files#diff-7c265d3c3ba08ac8cea3745daf2412e9R460

could also continue instead of ok = false and then find the number of filtered with len(rcs) - len(res) but probably less of a perf concern

@mmaxim

This comment has been minimized.

Member

mmaxim commented Nov 5, 2018

Ok sure, I'll make that change

map

@mmaxim mmaxim merged commit 4bc854b into master Nov 5, 2018

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
ci/circleci Your tests passed on CircleCI!
Details

@mmaxim mmaxim deleted the mike/inboxsigh branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment