[KBFS-3561] Fix downloads on Android

[jzila]

This might warrant a hotfix.

[taruti]

LGTM, but cannot test at the moment.

[songgao]

Would mime.mimeType not work?

[jzila]

Yes it works, I just like leaving explicit evidence that this is an immutable object in the code.

[songgao]

But it's not type-checked anymore right? For example, you could do mime.get('MimeType') and it'd pass flow, I think.

[jzila]

It appears to me that the type checking here is completely broken anyway, since Flow didn't catch this error in the first place.

[jzila]

Does type checking work for Immutable records e.g. with .mimeType?

[chrisnojima]

i agree, avoid get unless its a dynamic sub thing

[songgao]

It appears to me that the type checking here is completely broken anyway, since Flow didn't catch this error in the first place.

That can't be an argument for giving up type checking there right? I think the reason why flow didn't catch it was probably because of the less typed generator function. But perhaps something like this would work:

    const mimeType: Types.MimeType = yield Saga.call(_loadMimeType, path)

Also I'm guessing the type checking must be working in viewTypeFromMimeType.

[chrisnojima]

they flow type the same. .get isn't required for records and we shouldn't use it

[songgao]

LGTM; Thanks for making the changes!