New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt sbs resolution in tests #15191

merged 2 commits into from Jan 2, 2019


None yet
3 participants
Copy link

joshblum commented Dec 20, 2018

Fixes a bug where FindConversations fails to find an sbs conversation if the conversation already exists since we only search locally for the sbs name not the resolved name

@joshblum joshblum requested a review from mmaxim Dec 20, 2018

@@ -502,6 +503,16 @@ func FindConversations(ctx context.Context, g *globals.Context, debugger utils.D
topicName = globals.DefaultTeamTopic

// Attempt to resolve any sbs convs incase the team already exists.
var nameInfo *types.NameInfo
if strings.Contains(tlfName, "@") {

This comment has been minimized.


heronhaye Dec 20, 2018


Maybe : as well for keybase id

This comment has been minimized.


joshblum added some commits Dec 20, 2018

@joshblum joshblum force-pushed the joshblum/find-convs-CORE-9702 branch from c180996 to c08f783 Dec 20, 2018


This comment has been minimized.

Copy link

joshblum commented Jan 2, 2019

bump on this @mmaxim


mmaxim approved these changes Jan 2, 2019

@joshblum joshblum merged commit c6c4662 into master Jan 2, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/jenkins/pr-head This commit looks good

@joshblum joshblum deleted the joshblum/find-convs-CORE-9702 branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment