New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humanize err [CORE-9745] #15205

Merged
merged 2 commits into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@joshblum
Copy link
Member

joshblum commented Dec 21, 2018

let me know what you think of the wording! this error should never really appear unless there is a bug but i thought this would make it more clear

@joshblum joshblum requested a review from cecileboucheron Dec 21, 2018

@cecileboucheron

This comment has been minimized.

Copy link
Contributor

cecileboucheron commented Dec 21, 2018

The thing is that on desktop (vs. mobile) there is no feedback page - so let's just remove the second part.

@joshblum joshblum force-pushed the joshblum/err-msg branch from 3bf6055 to a808b4a Dec 21, 2018

@joshblum

This comment has been minimized.

Copy link
Member

joshblum commented Dec 21, 2018

fixed!

joshblum added some commits Dec 21, 2018

fix

@joshblum joshblum changed the title Humanize err Humanize err [CORE-9745] Dec 21, 2018

@mmaxim

This comment has been minimized.

Copy link
Member

mmaxim commented Dec 21, 2018

I wish this could be changed higher up in the stack.

@joshblum

This comment has been minimized.

Copy link
Member

joshblum commented Jan 2, 2019

error directly bubbles up to the UI so i feel this is the right place to change so we don't accidentally return it again in the future

@joshblum

This comment has been minimized.

Copy link
Member

joshblum commented Jan 2, 2019

we also have a bunch of logging around these errors in the existing methods so it is still easy to trace in the logs

@mmaxim

mmaxim approved these changes Jan 2, 2019

@joshblum joshblum merged commit 11ce2d9 into master Jan 2, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@joshblum joshblum deleted the joshblum/err-msg branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment