New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer upgrades #15265

wants to merge 12 commits into
base: mike/hotfix_2_12_4


None yet
2 participants
Copy link

mmaxim commented Jan 1, 2019

No description provided.

maxtaco and others added some commits Dec 29, 2018

relax the admin check and simplify the helper
- it's too restrictive to only let admins use the helper because some mac users use one-off admin privileges
- also let's simplify the helper and get rid of the "move" RPC which is dangerous; instead, just use user perms to install the app bundle
- also, check that only group staff can use the helper, so that low privilege accounts (like nobody) can't
stage kernel module moves in a root sanbox
- do the signature check there, and also check that it's a directory (not a symlink)
- factor out some of the code from keybase-redirector install to use the same code.

maxtaco approved these changes Jan 1, 2019

@mmaxim mmaxim closed this Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment