New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop ios from scrolling down as new content comes in if you're scrolled up #15272

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@chrisnojima
Copy link
Contributor

chrisnojima commented Jan 2, 2019

  • use maintainVisibleContentPosition prop to keep scrollview in place as new content comes in

to repro, on master load up a thread and scroll up a little bit. on another client message that thread. each message will push your mobile thread around, making reading back super annoying
this pr stops that from happening

@keybase/react-hackers

@mmaxim

mmaxim approved these changes Jan 2, 2019

@mmaxim

This comment has been minimized.

Copy link
Member

mmaxim commented Jan 2, 2019

Haven't tried it, but seems simple enough to try.

@MarcoPolo
Copy link
Contributor

MarcoPolo left a comment

I don't really understand how this works, but this looks good

@chrisnojima

This comment has been minimized.

@chrisnojima chrisnojima merged commit 7eab183 into master Jan 2, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@chrisnojima chrisnojima deleted the nojima/DESKTOP-thread-position branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment