New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require user is in group staff #15278

Merged
merged 3 commits into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@maxtaco
Copy link
Contributor

maxtaco commented Jan 2, 2019

  • this isn't a good idea on active directory systems
  • also, while we're upgrading the helper, let's also clamp down symlink creation
don't require user is in group staff
- this isn't a good idea on active directory systems
- also, while we're upgrading the helper, let's also clamp down symlink creation

@maxtaco maxtaco requested review from mmaxim and cjb Jan 2, 2019

@mmaxim
Copy link
Member

mmaxim left a comment

Need to bump helper

@mmaxim

mmaxim approved these changes Jan 2, 2019

Copy link
Member

mmaxim left a comment

Just make sure to get the installer on S3 before the next admin build (I can do that too if you want)

@maxtaco maxtaco merged commit 4b469d3 into master Jan 2, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details

@maxtaco maxtaco deleted the maxtaco/CORE-9781 branch Jan 2, 2019

mmaxim added a commit that referenced this pull request Jan 2, 2019

don't require user is in group staff (#15278)
* don't require user is in group staff

- this isn't a good idea on active directory systems
- also, while we're upgrading the helper, let's also clamp down symlink creation

* better formatting

* vbump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment