New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop LookupIDUntrusted since it messes up SBS sometimes CORE-9786 #15290

Merged
merged 3 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@mmaxim
Copy link
Member

mmaxim commented Jan 3, 2019

We need to get the real team name in GetInboxQueryLocalToRemote, otherwise SBS conversations can fail in strange ways. LookupIDUntrusted was getting a name which didn't match what we would get back from doing the team load, so let's just use LookupID (since it is plenty fast now) and delete LookupIDUntrusted.

@mmaxim mmaxim requested a review from joshblum Jan 3, 2019

@joshblum
Copy link
Member

joshblum left a comment

do we have to do anything if IdentifyFailures is non-nil on the LookupID call now?

@mmaxim

This comment has been minimized.

Copy link
Member

mmaxim commented Jan 3, 2019

No, we can probably move that to using a system like the rate limits, where we collect in the context at some point.

mmaxim added some commits Jan 3, 2019

@mmaxim mmaxim merged commit ca9c68d into master Jan 3, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/CORE-9786 branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment