New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for unsent text to be set in the store and fed into the input box CORE-9795 #15298

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@mmaxim
Copy link
Member

mmaxim commented Jan 3, 2019

@keybase/react-hackers

Patch does the following:

  1. Add a new map to the store, which maps convID -> unsentText. The purpose of this is to be able to override the module level unsent text with stuff from redux.
  2. In the input box component, if the unsent text is set in the store, then use it in getUnsentText() instead of whatever we have in the module level storage. We also set a flag to let the component know it should re-run getUnsentText() to get the new data in there.
  3. If the user types anything after that, we blow away the unsent text in the store.
  4. If a user cancels a Stellar in-chat send, then we set the unsent text in the store of the message they are composing.
@mmaxim

This comment has been minimized.

Copy link
Member

mmaxim commented Jan 3, 2019

Note: I also think this is a nice path forward for when the service is going to run this with drafts.

@mmaxim mmaxim merged commit f8fdddc into master Jan 4, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/CORE-9795-2 branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment