New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uninstall timeouts #15307

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@maxtaco
Copy link
Contributor

maxtaco commented Jan 4, 2019

  • the strategy is just to check that the root helper exists, and if not, don't try to make RPCs to it
  • most of the work we can try in the installer, or don't need to do in the installer
fix uninstall timeouts
- the strategy is just to check that the root helper exists, and if not, don't try to make RPCs to it
- most of the work we can try in the installer, or don't need to do in the installer

@maxtaco maxtaco requested a review from mmaxim Jan 4, 2019

@mmaxim

mmaxim approved these changes Jan 4, 2019

@maxtaco maxtaco merged commit 887f92b into master Jan 4, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@maxtaco maxtaco deleted the maxtaco/CORE-9814 branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment