New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keybase wallet api command #15308

Merged
merged 11 commits into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@patrickxb
Copy link
Contributor

patrickxb commented Jan 4, 2019

This adds a JSON API for the keybase wallet.

Also includes some minor refactoring of the other api commands where there was common code.

cc @malgorithms

patrickxb added some commits Jan 2, 2019

WIP

@patrickxb patrickxb requested a review from mmaxim Jan 4, 2019

@malgorithms

This comment has been minimized.

Copy link
Contributor

malgorithms commented Jan 4, 2019

prioritizing a review/merge of this would probably be nice, so bot work and testing can begin without having to run separate client. I'll do some testing myself once it's in master.

@mmaxim

mmaxim approved these changes Jan 4, 2019

Copy link
Member

mmaxim left a comment

🚢

@@ -7,12 +7,15 @@ import (
)

func newCmdWallet(cl *libcmdline.CommandLine, g *libkb.GlobalContext) cli.Command {
// please keep sorted

This comment has been minimized.

@mmaxim

mmaxim Jan 4, 2019

Member

Need that annoying eslint plugin thats used in JS land

@patrickxb patrickxb merged commit 8abfc8d into master Jan 4, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@patrickxb patrickxb deleted the patrickxb/CORE-9684 branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment