New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orange line #15309

Closed
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@joshblum
Copy link
Member

joshblum commented Jan 4, 2019

Consume orange line sent down from the server and keep local InboxSource up to date. Depends on server side: keybase/keybase#3301

major change is that on DELETE or DELETEHISTORY we throw a NewVersionMismatchError so we use the server's orange line value

@joshblum joshblum requested review from mmaxim and keybase/react-hackers Jan 4, 2019

// The reason is it is tricky to update max messages/orange line msg in
// this case.
switch msg.GetMessageType() {
case chat1.MessageType_DELETE, chat1.MessageType_DELETEHISTORY:

This comment has been minimized.

@mmaxim

mmaxim Jan 4, 2019

Member

We can't do this, for a big team like keybasefriends it creates a thundering herd.

@joshblum joshblum force-pushed the joshblum/orangeline-CORE-9433 branch from 872ca6c to 4153b5b Jan 4, 2019

@joshblum joshblum force-pushed the joshblum/orangeline-CORE-9433 branch from 4153b5b to 0a79c78 Jan 4, 2019

@joshblum

This comment has been minimized.

Copy link
Member

joshblum commented Jan 8, 2019

closing in favor of #15381

@joshblum joshblum closed this Jan 8, 2019

@joshblum joshblum deleted the joshblum/orangeline-CORE-9433 branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment