New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sending in-chat payment through JSON API CORE-9825 #15330

merged 6 commits into from Jan 5, 2019


None yet
2 participants
Copy link

mmaxim commented Jan 5, 2019

Patch does the following:

  1. Refactor how the chat UI's are delivered into chatServiceHandler so that the API and CLI can do different things.
  2. Split the client ChatUI into ChatAPIUI and ChatCLIUI since they behave differently.
  3. Thread through a new parameter to SendV1 that controls if ChatAPIUI will allow Stellar payments in the body to happen.
  4. Refactor how Stellar UI gets run in Server, and put it into use on the PostLocal and PostLocalNonblock paths.
  5. Fix a bug when posting nonblocking message from the chat JSON API so they show up in the UI properly.

cc @malgorithms

mmaxim added some commits Jan 5, 2019


@mmaxim mmaxim requested a review from patrickxb Jan 5, 2019

@mmaxim mmaxim merged commit 446972e into master Jan 5, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
continuous-integration/jenkins/pr-head This commit looks good

@mmaxim mmaxim deleted the mike/CORE-9825 branch Jan 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment