New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectiveSync fixes #15343

Merged
merged 4 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@joshblum
Copy link
Member

joshblum commented Jan 7, 2019

fixes the following for chat search background syncing:

  • adds chat.Context to the Indexer.Start call for debugging
  • adds SkipBgLoads flag to GetInboxQuery so the indexer does not enqueue any sync jobs
  • filters any KBFS conversation from being background loaded

KBFS convs are filtered in FetchedRemoteInbox instead of inside the loader since the loader only has a ConvID, it seems like it would be less efficient to load the conv from the inbox to get the members type to skip in the background loader

@joshblum joshblum requested a review from mmaxim Jan 7, 2019

@joshblum joshblum force-pushed the joshblum/indexer-fixes-CORE-9805 branch from b79f20c to 464d012 Jan 7, 2019

@mmaxim

mmaxim approved these changes Jan 7, 2019

@joshblum joshblum force-pushed the joshblum/indexer-fixes-CORE-9805 branch from 6f6c11c to 696e155 Jan 7, 2019

@joshblum joshblum merged commit 70647d5 into master Jan 8, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@joshblum joshblum deleted the joshblum/indexer-fixes-CORE-9805 branch Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment