New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand rpc canceling mechanism to backgrounding the app, and use on chat CORE-9768 #15375

Merged
merged 9 commits into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@mmaxim
Copy link
Member

mmaxim commented Jan 8, 2019

Patch does the following:

1.) Allow the RPC canceler to work with categories of cancelation so we can use some types with some protocols (like backgrounding, which most things are probably not ready to have cancel everything).
2.) Enable for the chat local protocol for background mode.
3.) Always send stale messages to UI, not just in foreground.

Goal of this PR is to make it so we don't have RPCs on the service live over the app getting suspended, which can cause bad results in the UI.

mmaxim added some commits Jan 8, 2019

wip
wip

@mmaxim mmaxim requested a review from patrickxb Jan 8, 2019

"golang.org/x/net/context"
)

func TestRPCCanceler(t *testing.T) {

This comment has been minimized.

@patrickxb

patrickxb Jan 8, 2019

Contributor

nice test...

@mmaxim mmaxim merged commit a860a6c into master Jan 9, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/CORE-9768 branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment