New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orangeline fixes #15381

Merged
merged 6 commits into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@joshblum
Copy link
Member

joshblum commented Jan 8, 2019

fixes when the orange line was selecting a non-visible message. the UI will try to compute this value on render and receives an update from getThreadNonblock with the value. this prevents any flickering in the UI if the messages are already in the frontend store.

  • add tests to the core side for getUnreadLine

@joshblum joshblum requested review from mmaxim and keybase/react-hackers Jan 8, 2019

@joshblum joshblum referenced this pull request Jan 8, 2019

Closed

Orange line #15309

@joshblum joshblum changed the title Orangelint fixes Orangeline fixes Jan 8, 2019

@joshblum joshblum force-pushed the joshblum/orangeline2-CORE-9433 branch from 6c0c850 to 7f97fc7 Jan 9, 2019

@mmaxim

mmaxim approved these changes Jan 9, 2019

@joshblum joshblum force-pushed the joshblum/orangeline2-CORE-9433 branch 2 times, most recently from 099477b to 0072cc9 Jan 9, 2019

@joshblum joshblum force-pushed the joshblum/orangeline2-CORE-9433 branch from 0072cc9 to 63af141 Jan 9, 2019

@joshblum joshblum merged commit ef4f71d into master Jan 9, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@joshblum joshblum deleted the joshblum/orangeline2-CORE-9433 branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment