Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply bot settings to choose chat keys #18673

Merged
merged 4 commits into from Aug 13, 2019

Conversation

@joshblum
Copy link
Member

commented Jul 31, 2019

determine what keys should be used during send by applying the BotSettings rules. If multiple bots match the first match is chosen, a subsequent PR will handle keying for multiple bots.

depends on keybase/keybase#4125

cc @keybase/hotpotatosquad

@joshblum joshblum requested a review from mmaxim Jul 31, 2019

@joshblum joshblum force-pushed the joshblum/botadd-HOTPOT-328 branch 2 times, most recently from ff3a15f to 59208eb Jul 31, 2019

@joshblum joshblum force-pushed the joshblum/boxbot-HOTPOT-118 branch from 43a25fb to 32c5b5a Jul 31, 2019

@joshblum joshblum force-pushed the joshblum/botadd-HOTPOT-328 branch from 59208eb to d88342d Jul 31, 2019

@joshblum joshblum force-pushed the joshblum/boxbot-HOTPOT-118 branch from 32c5b5a to dcfc8dd Jul 31, 2019

@joshblum joshblum force-pushed the joshblum/botadd-HOTPOT-328 branch 2 times, most recently from 0d17a06 to 1302a71 Aug 12, 2019

@joshblum joshblum force-pushed the joshblum/boxbot-HOTPOT-118 branch from dcfc8dd to cc3a423 Aug 12, 2019

go/chat/utils/utils.go Outdated Show resolved Hide resolved
@mmaxim

mmaxim approved these changes Aug 12, 2019

@joshblum joshblum force-pushed the joshblum/boxbot-HOTPOT-118 branch from f8bdd5e to da7f5d1 Aug 12, 2019

@joshblum joshblum changed the base branch from joshblum/botadd-HOTPOT-328 to master Aug 12, 2019

@joshblum joshblum force-pushed the joshblum/boxbot-HOTPOT-118 branch from 786c53c to 1fe2823 Aug 12, 2019

@joshblum joshblum force-pushed the joshblum/boxbot-HOTPOT-118 branch from 22271cf to 6262541 Aug 13, 2019

@joshblum

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

merging over unrelated chat test flake

@joshblum joshblum merged commit 5b28e9a into master Aug 13, 2019

0 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci CircleCI is running your tests
Details

@joshblum joshblum deleted the joshblum/boxbot-HOTPOT-118 branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.