Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add another stage to loading threads so we can skip the verifying keys step #18699

Merged
merged 26 commits into from Aug 5, 2019

Conversation

@mmaxim
Copy link
Member

commented Aug 1, 2019

Patch does the following:

  1. Adds the new UIThreadLoader which now fully implements GetThreadNonblock.
  2. Add a new stage to UIThreadLoader which runs Boxer.ValidSenderKey after we send up the full thread to the UI. The point of this is to get messages on the screen faster. Also, do some fancy footwork with caching in order to get messages into the cache only after all stages of unboxing are complete.
  3. Add an optional UnboxMode to chat contexts that allows the caller to control if Boxer runs ValidSenderKey (and possibly other things) or not. In addition, in UnboxModeQuick, we do not cache any results on disk.
  4. Add Boxer.ResolveSkippedUnboxed in order to run any checks that were skipped in any unbox mode other than UnboxModeFull.
  5. Make TransformSupersedes handle replies as well.
  6. Add a whole status bar UI for handling loading status.

mmaxim added some commits Jul 30, 2019

wip
fix
log
wip
wip

@mmaxim mmaxim requested a review from joshblum Aug 2, 2019

@mmaxim mmaxim marked this pull request as ready for review Aug 2, 2019

@mmaxim mmaxim requested a review from keybase/react-hackers Aug 2, 2019

@mmaxim mmaxim changed the title add another stage to loading threads so we can skip the verifying keys add another stage to loading threads so we can skip the verifying keys step Aug 2, 2019

mmaxim added some commits Aug 2, 2019

fix
@mmaxim

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

(I'm going to merge over the gocritic errors)

@mmaxim mmaxim merged commit 31fa1ec into master Aug 5, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details

@mmaxim mmaxim deleted the mike/HOTPOT-429 branch Aug 5, 2019

@@ -903,7 +948,7 @@ func (b *Boxer) unboxV2orV3orV4(ctx context.Context, boxed chat1.MessageBoxed,
BodyHash: bodyHashSigned,
HeaderHash: headerHash,
HeaderSignature: nil,
VerificationKey: &boxed.VerifyKey,
VerificationKey: &senderKeyToValidate,

This comment has been minimized.

Copy link
@joshblum

joshblum Aug 12, 2019

Member

how did this work before?

typ, _ := status.Typ()
t.Debug(ctx, "setUIStatus: displaying: %v", typ)
}
resCh <- displayed

This comment has been minimized.

Copy link
@joshblum

joshblum Aug 12, 2019

Member

maybe better in a defer in case a short circuit is added later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.