Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify GUI about breaks when FS_GUI identify behavior is used #18702

Merged
merged 8 commits into from Aug 9, 2019

Conversation

@songgao
Copy link
Member

commented Aug 1, 2019

No description provided.

@songgao songgao requested review from mmaxim, strib and keybase/react-hackers Aug 1, 2019

@songgao songgao force-pushed the songgao/HOTPOT-33 branch from 0598d24 to 8332748 Aug 5, 2019

@songgao songgao force-pushed the songgao/HOTPOT-300 branch from 06ceb11 to 5eb4eef Aug 5, 2019

@songgao songgao force-pushed the songgao/HOTPOT-33 branch from 8332748 to 4d8a50a Aug 6, 2019

@songgao songgao force-pushed the songgao/HOTPOT-300 branch 2 times, most recently from bea2bfc to add1e96 Aug 6, 2019

@songgao songgao force-pushed the songgao/HOTPOT-33 branch from 4d8a50a to 6fb84b9 Aug 7, 2019

@strib

strib approved these changes Aug 7, 2019

Copy link
Contributor

left a comment

SimpleFS side seems fine, though ideally we could dedup the extended identify code.

go/kbfs/simplefs/simplefs.go Outdated Show resolved Hide resolved
@mmaxim

mmaxim approved these changes Aug 8, 2019

@songgao songgao force-pushed the songgao/HOTPOT-300 branch from 43d049d to 23f2819 Aug 9, 2019

@songgao songgao changed the base branch from songgao/HOTPOT-33 to master Aug 9, 2019

@songgao songgao force-pushed the songgao/HOTPOT-300 branch 2 times, most recently from a7f2780 to 53a1289 Aug 9, 2019

@songgao songgao force-pushed the songgao/HOTPOT-300 branch from 53a1289 to 4a0ddbd Aug 9, 2019

songgao added some commits Aug 9, 2019

go
@songgao

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

finally

@songgao songgao merged commit e5c1c6c into master Aug 9, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@songgao songgao deleted the songgao/HOTPOT-300 branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.