Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly ask for location perm on android #18726

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@mmaxim
Copy link
Member

commented Aug 2, 2019

Should get in for the release.

@mmaxim mmaxim requested a review from keybase/react-hackers Aug 2, 2019

@@ -47,6 +47,22 @@ const requestPermissionsToWrite = (): Promise<void> => {
return Promise.resolve()
}

const requestLocationPermission = (): Promise<void> => {

This comment has been minimized.

Copy link
@chrisnojima

chrisnojima Aug 2, 2019

Contributor

why not make this async too

@mmaxim mmaxim merged commit cc87632 into master Aug 2, 2019

1 of 2 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/HOTPOT-346 branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.