Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type mobile.native #18764

Merged
merged 9 commits into from Aug 7, 2019

Conversation

@chrisnojima
Copy link
Contributor

commented Aug 3, 2019

No description provided.

chrisnojima added some commits Aug 3, 2019

WIP
WIP
WIP
WIP
WIP
WIP

@chrisnojima chrisnojima changed the title WIP: Type mobile.native Type mobile.native Aug 3, 2019

@@ -25,7 +25,6 @@ const LongPressable = (props: {children: React.ElementType; onSwipeLeft: () => v
onSwipeableRightWillOpen={onRightOpen}
friction={2}
rightThreshold={100}
failOffsetX={0}

This comment has been minimized.

Copy link
@chrisnojima

chrisnojima Aug 3, 2019

Author Contributor

doesn't actually exist as a prop : cc: @mmaxim

This comment has been minimized.

Copy link
@mmaxim

mmaxim Aug 6, 2019

Member

We can't remove this, it exists on the underlying thing. Removing this will break swiping back to the inbox, just ts-ignore.

</Box>
)
const notification = {message: bannerEl, type: 'error'}
const notification = {message: 'This conversation needs to be rekeyed.', type: 'error' as const}

This comment has been minimized.

Copy link
@chrisnojima

chrisnojima Aug 3, 2019

Author Contributor

actual issue, this takes a string or a more complicated structure now

{!!hasThumbnail && (
<Kb.Box style={{...Styles.globalStyles.flexBoxRow, alignItems: 'center', flex: 1}}>
<Kb.Box style={{...Styles.globalStyles.flexBoxRow, alignItems: 'center', flex: 1}}>
{!!hasThumbnail && !!source && (

This comment has been minimized.

Copy link
@chrisnojima

chrisnojima Aug 3, 2019

Author Contributor

need a source check here

@@ -9,6 +9,7 @@
"jsx": "preserve",
"lib": ["es2017", "dom"],
"module": "commonjs",
"noErrorTruncation": true,

This comment has been minimized.

Copy link
@chrisnojima

chrisnojima Aug 3, 2019

Author Contributor

don't cut off errors

@chrisnojima chrisnojima marked this pull request as ready for review Aug 3, 2019

@chrisnojima

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2019

@keybase/react-hackers this finally types mobile.native.js (now tsx)

@chrisnojima

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@songgao

songgao approved these changes Aug 5, 2019

<Text
type="BodySmall"
negative={true}
style={{color: globalColors.blueLighter_40, lineHeight: 17} as any}

This comment has been minimized.

Copy link
@songgao

songgao Aug 5, 2019

Member

Why does it need any here? If the color isn't in the Text's allowed list perhaps fix the color or add this on to list?

This comment has been minimized.

Copy link
@chrisnojima

chrisnojima Aug 6, 2019

Author Contributor

we'd have to talk to @cecileboucheron

This comment has been minimized.

Copy link
@cecileboucheron

cecileboucheron Aug 6, 2019

Contributor

This whole screen needs to be revamped with a white background.

@mmaxim
Copy link
Member

left a comment

See my comment on long pressable

WIP

@chrisnojima chrisnojima requested a review from mmaxim Aug 6, 2019

fix types and modernize some devices (#18765)
* fix types and modernize some devices

* WIP

* WIP

@chrisnojima chrisnojima merged commit 821deed into nojima/HOTPOT-411-any-1 Aug 7, 2019

1 check was pending

ci/circleci CircleCI is running your tests
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.