Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetVerifiedConv shouldnt get stuck on localizer suspend #18817

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@mmaxim
Copy link
Member

commented Aug 7, 2019

We try to interrupt unboxing inbox items if a fetch of a thread comes in. However, it is possible that we can get stuck outside of deadlock detection's grasp if we try to do a simple load from within a cancelable context like a GetInboxNonblock that triggers a thread expunge (from a retention policy).

cc @joshblum

@mmaxim mmaxim requested a review from patrickxb Aug 7, 2019

@mmaxim mmaxim merged commit 9101577 into master Aug 7, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details

@mmaxim mmaxim deleted the mike/HOTPOT-522 branch Aug 7, 2019

mmaxim added a commit that referenced this pull request Aug 7, 2019

mmaxim added a commit that referenced this pull request Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.