Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message drafts #18831

Merged
merged 13 commits into from Aug 9, 2019

Conversation

@mmaxim
Copy link
Member

commented Aug 8, 2019

Add support for storing unsent messages in the service, as well as more adornment in the UI when these drafts exist. The flow is the following:

  1. UpdateUnsentText is called currently when the user is typing, so inside save drafts in Inbox storage.
  2. Attach drafts to inbox items we send up from GetInboxNonblock
  3. In the UI we display the draft in the snippet for small team rows, and as a pencil icon for big team rows. We don't show the draft state when the row is selected.
  4. Sub in draft text in the input area in the case where it is blank and the draft exists.

mmaxim added some commits Aug 7, 2019

wip

@mmaxim mmaxim marked this pull request as ready for review Aug 8, 2019

@mmaxim mmaxim requested review from keybase/react-hackers and joshblum Aug 8, 2019

mmaxim added some commits Aug 8, 2019

fix
@buoyad
Copy link
Member

left a comment

Cool, JS looks pretty straightforward. Couple comments.

shared/constants/types/chat2/index.tsx Outdated Show resolved Hide resolved
shared/constants/types/chat2/meta.tsx Outdated Show resolved Hide resolved

@mmaxim mmaxim requested a review from buoyad Aug 9, 2019

@buoyad

buoyad approved these changes Aug 9, 2019

@mmaxim mmaxim merged commit d37ec6e into master Aug 9, 2019

1 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/HOTPOT-105-2 branch Aug 9, 2019

@mmaxim mmaxim restored the mike/HOTPOT-105-2 branch Aug 9, 2019

@mmaxim mmaxim deleted the mike/HOTPOT-105-2 branch Aug 9, 2019

@mmaxim mmaxim restored the mike/HOTPOT-105-2 branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.