Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate join/leave messages #18849

merged 19 commits into from Aug 11, 2019


Copy link

commented Aug 8, 2019

Goal of the patch is to consolidate adjacent join/leave messages into a single message. Works using the new UIThreadLoader module to modify the thread on the way to the UI.

  1. Add grouping functionality in `UIThreadLoader.
  2. Improve logic for figuring out how to manage the multiple forms of state these messages can be in during LoadNonblock.
  3. Modify the UI join/leave messages to show multiple people (except for your own join message which we do not consolidate)

mmaxim added some commits Aug 8, 2019


@mmaxim mmaxim marked this pull request as ready for review Aug 9, 2019

@mmaxim mmaxim requested review from joshblum and keybase/react-hackers Aug 9, 2019

shared/constants/chat2/index.tsx Outdated Show resolved Hide resolved

mmaxim added some commits Aug 11, 2019

@mmaxim mmaxim requested a review from chrisnojima Aug 11, 2019

@mmaxim mmaxim merged commit 466a70a into master Aug 11, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
ci/circleci Your tests passed on CircleCI!

@mmaxim mmaxim deleted the mike/HOTPOT-426 branch Aug 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.