Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preview conversation #18876

Merged
merged 7 commits into from Aug 12, 2019

Conversation

@mmaxim
Copy link
Member

commented Aug 11, 2019

  1. Allow GetUnverifiedConv and GetVerifiedConv to lookup any conv regardless of member status.
  2. Change PreviewConversationByIDLocal to return the conversation InboxUIItem for it.
  3. Change preview conversation saga to save the meta for that conv before selecting it.

mmaxim added some commits Aug 11, 2019

@mmaxim mmaxim requested review from joshblum and keybase/react-hackers Aug 11, 2019

mmaxim added some commits Aug 11, 2019

@buoyad

buoyad approved these changes Aug 12, 2019

@mmaxim mmaxim merged commit 416ffb9 into master Aug 12, 2019

1 check was pending

ci/circleci CircleCI is running your tests
Details

@mmaxim mmaxim deleted the mike/HOTPOT-543 branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.