Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't ignore the next resize when switching convs #18907

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@mmaxim
Copy link
Member

commented Aug 13, 2019

If you switch convs on desktop, there is a chance the view is not scrolled all the way to the bottom. The reason is often times the size of the content changes after the thread loads. If we ignore the next resize as a result of switching convs, we might just miss that resize and do nothing, causing the scroll position to be incorrect.

mmaxim added some commits Aug 13, 2019

@mmaxim mmaxim requested a review from keybase/react-hackers Aug 13, 2019

@mmaxim mmaxim merged commit 768fb34 into master Aug 14, 2019

1 of 2 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/HOTPOT-539 branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.