Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter non-members from bulksystem messages #18934

Merged
merged 3 commits into from Sep 3, 2019

Conversation

@joshblum
Copy link
Member

commented Aug 14, 2019

No description provided.

@joshblum joshblum requested a review from mmaxim Aug 14, 2019

@joshblum joshblum force-pushed the joshblum/filterbulk-HOTPOT-563 branch from cc8977a to 99e31e4 Aug 14, 2019

@joshblum

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

(ci is a flake)


// filter the usernames for people that are actually part of the team
for _, username := range usernames {
uid, err := t.G().GetUPAKLoader().LookupUID(ctx, libkb.NewNormalizedUsername(username))

This comment has been minimized.

Copy link
@mmaxim

mmaxim Aug 16, 2019

Member

Could just use UIDMapper

This comment has been minimized.

Copy link
@joshblum

joshblum Aug 17, 2019

Author Member

that goes username -> uid though

go/chat/uithreadloader.go Outdated Show resolved Hide resolved

@joshblum joshblum force-pushed the joshblum/filterbulk-HOTPOT-563 branch from 99e31e4 to a919699 Aug 17, 2019

@joshblum joshblum requested a review from mmaxim Aug 19, 2019

go/chat/uithreadloader.go Outdated Show resolved Hide resolved

@joshblum joshblum force-pushed the joshblum/filterbulk-HOTPOT-563 branch from a919699 to a95b92d Aug 28, 2019

@joshblum joshblum requested a review from mmaxim Aug 28, 2019

@joshblum

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

@mmaxim this is ready

@mmaxim
mmaxim approved these changes Sep 3, 2019

@joshblum joshblum merged commit fb8e712 into master Sep 3, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@joshblum joshblum deleted the joshblum/filterbulk-HOTPOT-563 branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.