Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Message on SBS resolution #18961

Merged
merged 10 commits into from Sep 17, 2019

Conversation

@jakob223
Copy link
Contributor

commented Aug 15, 2019

The frontend part of this is ~done, but the message isn't actually being injected; rather than spending a bunch of time debugging a bunch of chat code I'm not familiar with, @mmaxim is there anything obviously wrong there?

Also, if you could do a preliminary review so that any large scale changes can happen before I go back and clean stuff up, that would be great 馃檱 .

@jakob223

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

@mmaxim bump

@jakob223

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2019

Oh, I realized you're OOO this week, this can wait.

@mmaxim

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

K you should request a review from me on the right side, I might ignore anything else.

@jakob223 jakob223 requested a review from mmaxim Aug 21, 2019

@jakob223

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

bump @mmaxim

1 similar comment
@jakob223

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

bump @mmaxim

@mmaxim
mmaxim approved these changes Sep 3, 2019
go/teams/chatmessaging.go Outdated Show resolved Hide resolved
go/teams/handler.go Outdated Show resolved Hide resolved

@jakob223 jakob223 marked this pull request as ready for review Sep 4, 2019

@jakob223 jakob223 requested a review from zapu Sep 4, 2019

@jakob223 jakob223 force-pushed the jakob/y2k-392-system-message-on-sbs-resolve branch from a5d3a65 to 2cf6c69 Sep 4, 2019

go/teams/handler.go Outdated Show resolved Hide resolved
jakob223 added 5 commits Aug 15, 2019

@jakob223 jakob223 requested a review from zapu Sep 5, 2019

@jakob223 jakob223 force-pushed the jakob/y2k-392-system-message-on-sbs-resolve branch from eef785e to 6b36175 Sep 5, 2019

@jakob223 jakob223 force-pushed the jakob/y2k-392-system-message-on-sbs-resolve branch from 3169d77 to b51436d Sep 9, 2019

go/teams/handler.go Outdated Show resolved Hide resolved

@jakob223 jakob223 force-pushed the jakob/y2k-392-system-message-on-sbs-resolve branch from bfe671f to 3954575 Sep 11, 2019

@jakob223 jakob223 requested a review from zapu Sep 16, 2019

@zapu
zapu approved these changes Sep 17, 2019
@jakob223

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2019

merging over docker errors that are happening on master too

@jakob223 jakob223 merged commit 4ade774 into master Sep 17, 2019

1 check was pending

ci/circleci Your tests are queued behind your running builds
Details

@jakob223 jakob223 deleted the jakob/y2k-392-system-message-on-sbs-resolve branch Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.