Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surya/y2 k 460/service driven contact syncs #19023

Merged
merged 7 commits into from Sep 4, 2019

Conversation

@heronhaye
Copy link
Contributor

commented Aug 20, 2019

No description provided.

@heronhaye heronhaye requested a review from buoyad Aug 21, 2019

@heronhaye heronhaye force-pushed the surya/Y2K-460/service-driven-contact-syncs branch from 38a004e to a232f1a Aug 21, 2019

@jakob223

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

// background passive'd.
MobileForegroundStartAddition: 1 * time.Minute,
StartStagger: 5 * time.Second,
WakeUp: 15 * time.Second,

This comment has been minimized.

Copy link
@heronhaye

heronhaye Aug 29, 2019

Author Contributor

this should wait at most 25 seconds in background fetch mode. Should I reduce it?

@heronhaye heronhaye requested a review from mmaxim Aug 29, 2019

@heronhaye

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

@buoyad ptal as well - if you trigger bg fetch you should get a notification within 40 seconds now

@heronhaye heronhaye force-pushed the surya/Y2K-460/service-driven-contact-syncs branch from e0c3db8 to 483dcce Aug 29, 2019

@heronhaye heronhaye force-pushed the surya/Y2K-460/service-driven-contact-syncs branch from 9823986 to 597de47 Sep 3, 2019

@buoyad
buoyad approved these changes Sep 3, 2019
Copy link
Member

left a comment

Got a few successful test notifications profiling this over the weekend. :shipit:

@heronhaye

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

@mmaxim take a look? ci failure is a flake

@heronhaye

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

ping @mmaxim

@mmaxim
mmaxim approved these changes Sep 4, 2019

@heronhaye heronhaye merged commit 17a45d7 into master Sep 4, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details

@heronhaye heronhaye deleted the surya/Y2K-460/service-driven-contact-syncs branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.