Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go back to inbox on bad chat team loads #19251

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@chrisnojima
Copy link
Contributor

commented Sep 3, 2019

Alice is desktop , bob is phone, T is team

  1. Bob adds Alice to T
  2. Alice goes offline
  3. Bob removes Alice from T
  4. Alice comes back online

Before:
Several black bars about not being in the team
After:
Inbox refreshes and that team should no longer be listed

WIP

@chrisnojima chrisnojima requested a review from keybase/react-hackers Sep 3, 2019

@mmaxim
mmaxim approved these changes Sep 4, 2019

@chrisnojima chrisnojima merged commit d2302bb into master Sep 4, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@chrisnojima chrisnojima deleted the nojima/HOTPOT-709-inbox-on-error branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.