Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location followup #19266

Merged
merged 8 commits into from Sep 4, 2019

Conversation

@mmaxim
Copy link
Member

commented Sep 4, 2019

@mmaxim mmaxim requested a review from joshblum Sep 4, 2019

@mmaxim

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

Difference is live location button subtitles and the lack of green start pin.

@mmaxim mmaxim requested a review from buoyad Sep 4, 2019

@mmaxim

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

Added a subLabel prop to Button too, cc @buoyad

mmaxim added 2 commits Sep 4, 2019
@mmaxim

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

All the shots changes are from that extra box.

@joshblum
Copy link
Member

left a comment

re go

mmaxim added 3 commits Sep 4, 2019
@buoyad
buoyad approved these changes Sep 4, 2019

@mmaxim mmaxim merged commit 20950e0 into master Sep 4, 2019

0 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci CircleCI is running your tests
Details

@mmaxim mmaxim deleted the mike/locationfollowup branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.