Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple UIs in JSON api #19275

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@joshblum
Copy link
Member

commented Sep 4, 2019

fixes an issue where the JSON api would use the first chatUI what was registered regardless of what the caller tried to regegister. ChatAPIUI and ChatCLIUI (both used within the API) now have a random sessionID parameter which delegates ui rpc calls via the sessionID

@joshblum joshblum requested a review from mmaxim Sep 4, 2019

@joshblum joshblum referenced this pull request Sep 4, 2019
@mmaxim
mmaxim approved these changes Sep 4, 2019
@joshblum

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

merging over known flake

@joshblum joshblum merged commit 7b98b26 into master Sep 4, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details

@joshblum joshblum deleted the joshblum/apifix-HOTPOT-772 branch Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.