Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-dupe conv loader jobs #19304

Merged
merged 5 commits into from Sep 6, 2019

Conversation

@mmaxim
Copy link
Member

commented Sep 5, 2019

Goal is to de-dupe jobs into the conv loader, while giving special treatment to jobs that have a special post load hook.

mmaxim added 3 commits Sep 5, 2019

@mmaxim mmaxim requested a review from joshblum Sep 5, 2019

mmaxim added 2 commits Sep 5, 2019

@mmaxim mmaxim merged commit d4d4365 into master Sep 6, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/HOTPOT-769 branch Sep 6, 2019

task.lastAttemptAt = time.Now()
return &task
var tv chat1.ThreadView
if pagination.Num > 0 {

This comment has been minimized.

Copy link
@joshblum

joshblum Sep 6, 2019

Member

I would prefer this was an explicit option to not run Pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.