Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pin/unpin to json api #19348

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@joshblum
Copy link
Member

commented Sep 9, 2019

No description provided.

@joshblum joshblum requested a review from mmaxim Sep 9, 2019

@@ -2727,10 +2727,29 @@ func (h *Server) PinMessage(ctx context.Context, arg chat1.PinMessageArg) (res c
ctx = globals.ChatCtx(ctx, h.G(), keybase1.TLFIdentifyBehavior_CHAT_GUI, &identBreaks, h.identNotifier)
defer h.Trace(ctx, func() error { return err }, "PinMessage")()
defer func() { h.setResultRateLimit(ctx, &res) }()
_, err = utils.AssertLoggedInUID(ctx, h.G())
uid, err := utils.AssertLoggedInUID(ctx, h.G())

This comment has been minimized.

Copy link
@mmaxim

mmaxim Sep 10, 2019

Member

Maybe we should just do this check on the server.

This comment has been minimized.

Copy link
@joshblum

joshblum Sep 10, 2019

Author Member

can't since the id of the msg we're pinning is in the body

This comment has been minimized.

Copy link
@joshblum

joshblum Sep 10, 2019

Author Member

i saw this more of a nicety of trying to prevent accidental pins than a strict enforcement

This comment has been minimized.

Copy link
@mmaxim

mmaxim Sep 10, 2019

Member

Could include on supersedes, but sounds good.

@mmaxim
mmaxim approved these changes Sep 10, 2019

@joshblum joshblum merged commit b889569 into master Sep 10, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@joshblum joshblum deleted the joshblum/pinapi-HOTPOT-715 branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.