Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always get tlfname summary in localize #19498

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@mmaxim
Copy link
Member

commented Sep 11, 2019

  • Always get TLFNAME max message from summaries in case other messages are no good for old members types.
  • Remove getMessagesOffline, the errors should just flow naturally out of the normal flow.
  • Return a better error in the case where we can't get any name for the conv from messages.
mmaxim added 3 commits Sep 11, 2019

@mmaxim mmaxim requested a review from joshblum Sep 11, 2019

@mmaxim mmaxim merged commit b082e3f into master Sep 11, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details

@mmaxim mmaxim deleted the mike/HOTPOT-778 branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.