Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling of team delete #20070

Merged
merged 4 commits into from Oct 2, 2019

Conversation

@mmaxim
Copy link
Member

commented Oct 2, 2019

Two things:

  1. Ignore the error from TombstoneTeam (this was a change because of the linting PRs...)
  2. Change cache clear order in TombstoneTeam so hidden chain goes last, otherwise it gets a tombstone error in itself.

cc @buoyad

@mmaxim mmaxim requested review from maxtaco and heronhaye Oct 2, 2019
Copy link
Contributor

left a comment

thanks. maybe make that CDebugf a warning so we might notice it in devel?

mmaxim added 2 commits Oct 2, 2019
errs = append(errs, err)
continue
if err := FreezeTeam(mctx, row.Id); err != nil {
mctx.Debug("team.HandleExitNotification: failed to FreezeReam: %s", err)

This comment has been minimized.

Copy link
@patrickxb

patrickxb Oct 2, 2019

Contributor

FreezeReam

@mmaxim mmaxim merged commit 4a69a8f into master Oct 2, 2019
1 check was pending
1 check was pending
ci/circleci Your tests are queued behind your running builds
Details
@mmaxim mmaxim deleted the mike/teamfixes branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.