Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send system messages when adding a bot member, display role in added to team system messages #20081

Merged
merged 4 commits into from Oct 7, 2019

Conversation

@joshblum
Copy link
Member

commented Oct 2, 2019

  • 1-1 chats now get a join message when adding a bot/restricted bot member
  • role is printed with system join messages

Screen Shot 2019-10-02 at 4 24 51 PM

teamchat:
image

1-1 chat:
image

cc @adamjspooner

@joshblum joshblum marked this pull request as ready for review Oct 2, 2019
@joshblum joshblum changed the title Send system messages when adding a bot member, display role in added … Send system messages when adding a bot member, display role in added to team system messages Oct 2, 2019
@joshblum joshblum requested review from mmaxim and keybase/react-hackers Oct 2, 2019
@joshblum joshblum force-pushed the joshblum/botsys-HOTPOT-869 branch 2 times, most recently from 9571f67 to 4dbae41 Oct 2, 2019
@joshblum

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

(ci flake unrelated)

Copy link
Contributor

left a comment

TS looks good with a few nits

@joshblum joshblum force-pushed the joshblum/botsys-HOTPOT-869 branch from fb86485 to b7554a0 Oct 4, 2019
@mmaxim
mmaxim approved these changes Oct 7, 2019
@joshblum joshblum merged commit abd706c into master Oct 7, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details
@joshblum joshblum deleted the joshblum/botsys-HOTPOT-869 branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.