Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct name in layout notification #20089

Merged
merged 8 commits into from Oct 3, 2019

Conversation

@mmaxim
Copy link
Member

commented Oct 2, 2019

Also hit a layout message upon reception of subteam rename.

cc @buoyad

mmaxim added 2 commits Oct 2, 2019
fix
@mmaxim mmaxim requested a review from joshblum Oct 2, 2019
go/chat/uiinboxloader.go Outdated Show resolved Hide resolved
fix
@buoyad

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Confirmed to fix the repro I had 👍

@@ -938,6 +938,30 @@ func GetConvMtimeLocal(conv chat1.ConversationLocal) gregor1.Time {
return msg.Ctime
}

func GetRemoteConvTLFName(conv types.RemoteConversation) string {
if conv.LocalMetadata != nil {

This comment has been minimized.

Copy link
@mmaxim

mmaxim Oct 2, 2019

Author Member

The real key part of the fix

mmaxim added 4 commits Oct 3, 2019
@mmaxim mmaxim merged commit e2fb8fe into master Oct 3, 2019
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@mmaxim mmaxim deleted the mike/inboxfixes branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.