Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libkb: clear stale bit after refresh #20096

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@maxtaco
Copy link
Contributor

commented Oct 3, 2019

  • if the stale bit was set, it wasn't getting set to false after a refresh
  • this was causing uncessary round-trips
@maxtaco maxtaco requested a review from mmaxim Oct 3, 2019
- if the stale bit was set, it wasn't getting set to false after a refresh
- this was causing uncessary round-trips
@maxtaco maxtaco force-pushed the maxtaco/fix-merkle-repoll-on-stale branch from 1408ad8 to 8ba62dd Oct 3, 2019
@@ -294,6 +294,13 @@ func (u *CachedUPAKLoader) putUPAKToCache(ctx context.Context, obj *keybase1.Use
uid := obj.Current.Uid
u.G().VDL.CLogf(ctx, VLog0, "| Caching UPAK for %s %s", uid, stubMode)

// At this point, we've gone to the server, and we checked that the user is fresh, so if we previously had a stale
// bit set for this user, we'll turn it off now.

This comment has been minimized.

Copy link
@mmaxim

mmaxim Oct 3, 2019

Member

We are sure this can't be called on any other code path other than after fetching from server?

This comment has been minimized.

Copy link
@maxtaco

maxtaco Oct 3, 2019

Author Contributor

To the best of my knowledge.

@maxtaco maxtaco merged commit 6926088 into master Oct 3, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
Details
ci/circleci Your tests passed on CircleCI!
Details
@maxtaco maxtaco deleted the maxtaco/fix-merkle-repoll-on-stale branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.