Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update animated images for dark mode. #20129

Merged
merged 25 commits into from Oct 4, 2019

Conversation

@adamjspooner
Copy link
Member

commented Oct 4, 2019

@keybase/react-hackers, this is ready for review. This replaces all but one animated gif with Lottie animations.

@hyperobject

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

the spinner when loading an image attachment is teeny tiny with this pr

this pr:
Screen Shot 2019-10-04 at 10 20 32 AM

master:
Screen Shot 2019-10-04 at 10 20 40 AM

@adamjspooner

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

Good catch! I'll have a fix shortly.

@adamjspooner

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

@hyperobject, this is ready for another look.

@mmaxim
mmaxim approved these changes Oct 4, 2019
@adamjspooner adamjspooner merged commit dd95836 into master Oct 4, 2019
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@adamjspooner adamjspooner deleted the spooner/DESIGN-2605-dark-mode-animations branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.