Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search highlights on mobile for dark mode. #20154

Merged

Conversation

@adamjspooner
Copy link
Member

commented Oct 5, 2019

@keybase/react-hackers, this is ready for review.

@@ -408,7 +408,7 @@ class _WrapperMessage extends React.Component<Props & Kb.OverlayParentProps, Sta
case 'text':
exploded = message.exploded
explodedBy = message.explodedBy
child = <TextMessage key="text" message={message} />
child = <TextMessage isHighlighted={this.props.centeredOrdinal !== 'none'} key="text" message={message} />

This comment has been minimized.

Copy link
@mmaxim

mmaxim Oct 5, 2019

Member

Use this._showCenteredHighlight here

@mmaxim
mmaxim approved these changes Oct 5, 2019
@adamjspooner adamjspooner merged commit 3439b0b into master Oct 5, 2019
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@adamjspooner adamjspooner deleted the spooner/DESIGN-dark-mode-search-highlight-mobile branch Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.