Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow online login from share extension #20161

Merged
merged 3 commits into from Oct 7, 2019

Conversation

@mmaxim
Copy link
Member

commented Oct 7, 2019

No description provided.

@maxtaco

This comment has been minimized.

Copy link
Contributor

commented Oct 7, 2019

this seems fine, can we make an enum rather than a bool? Or maybe pass the preferred login technique to StartLoopbackServer?

@mmaxim mmaxim marked this pull request as ready for review Oct 7, 2019
mmaxim added 2 commits Oct 7, 2019
@mmaxim mmaxim requested a review from maxtaco Oct 7, 2019
@maxtaco
maxtaco approved these changes Oct 7, 2019
@mmaxim mmaxim merged commit 6beb398 into master Oct 7, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head The build of this commit was aborted
Details
ci/circleci Your tests passed on CircleCI!
Details
@mmaxim mmaxim deleted the mike/HOTPOT-938 branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.