Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont filter convs we unbox #20171

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@mmaxim
Copy link
Member

commented Oct 7, 2019

Fixes hidden convs never being unboxed. We don't need to filter since nothing shows up in the layout that is filtered, regardless of presence of meta in the map.

cc @buoyad

@mmaxim mmaxim requested a review from joshblum Oct 7, 2019
@mmaxim mmaxim merged commit b39c78e into master Oct 7, 2019
0 of 2 checks passed
0 of 2 checks passed
ci/circleci Your tests are queued behind your running builds
Details
continuous-integration/jenkins/pr-head This commit is being built
Details
@mmaxim mmaxim deleted the mike/alwasyunbox branch Oct 7, 2019
mmaxim added a commit that referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.