Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back mspack #20683

Merged
merged 6 commits into from Nov 4, 2019

Conversation

@chrisnojima
Copy link
Contributor

chrisnojima commented Oct 30, 2019

  • maybe stack needs to be more conservative?
chrisnojima added 5 commits Oct 29, 2019
This reverts commit 740027f.
WIP
…ck-wtf-2
WIP
WIP
@chrisnojima chrisnojima marked this pull request as ready for review Oct 31, 2019
@chrisnojima

This comment has been minimized.

Copy link
Contributor Author

chrisnojima commented Oct 31, 2019

turns out this was the issue. using what buffer does which seems to run fine

WIP
@chrisnojima

This comment has been minimized.

Copy link
Contributor Author

chrisnojima commented Nov 4, 2019

@mmaxim
mmaxim approved these changes Nov 4, 2019
@chrisnojima chrisnojima merged commit e1ff410 into master Nov 4, 2019
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@chrisnojima chrisnojima deleted the nojima/HOTPOT-msgpack-wtf-2 branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.