Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

journeycard changes #20709

merged 1 commit into from Nov 1, 2019


Copy link

mlsteele commented Oct 30, 2019

Add allowUnseenQuery to make it possible to ask the inbox whether other convs have been joined.

Handle interactions between cards. Split checkers out so PickCard is smaller.

cc @mmaxim

@@ -209,6 +209,9 @@
boolean computeActiveList;
boolean summarizeMaxMsgs; // if true, resulting conversation will only have summaries of max msgs
boolean skipBgLoads; // optionally skip queuing the conversation in the background loader.
// Normally a query that has not been seen before will return an error.
// With allowUnseenQuery, an unfamiliar query is accepted.
boolean allowUnseenQuery;

This comment has been minimized.

Copy link

mlsteele Oct 31, 2019

Author Contributor

@mmaxim hopefully this is an ok place to add this. Much more convenient than changing Read's signature.

@mlsteele mlsteele requested a review from patrickxb Oct 31, 2019
Copy link

patrickxb left a comment

LGTM, but @mmaxim should approve as well.

@mlsteele mlsteele requested a review from mmaxim Oct 31, 2019

This comment has been minimized.

Copy link
Contributor Author

mlsteele commented Nov 1, 2019

CI failed on TestChatSrvDeleteConversation which looks like a chat flake. And recursively deleting a directory. I'm going to consider this to have passed.

mmaxim approved these changes Nov 1, 2019
@mlsteele mlsteele merged commit 04a6949 into master Nov 1, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head This commit cannot be built
ci/circleci Your tests passed on CircleCI!
@mlsteele mlsteele deleted the miles/PICNIC-559-chat-team-journey-4 branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.