Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show instruction tooltip on audio short tap #20750

Merged
merged 13 commits into from Nov 4, 2019

Conversation

@mmaxim
Copy link
Contributor

mmaxim commented Nov 1, 2019

I'd recommend hiding whitespace changes.

mmaxim added 2 commits Nov 1, 2019
kb
@mmaxim mmaxim requested a review from keybase/react-hackers Nov 1, 2019
mmaxim added 11 commits Nov 1, 2019
fix
tsc
@mmaxim

This comment has been minimized.

Copy link
Contributor Author

mmaxim commented Nov 4, 2019

Made a bunch of changes to this over the weekend, but it is ready.

@chrisnojima chrisnojima self-assigned this Nov 4, 2019
action: Chat2Gen.EnableAudioRecordingPayload,
logger: Saga.SagaLogger
) => {
const conversationIDKey = action.payload.conversationIDKey

This comment has been minimized.

Copy link
@chrisnojima

chrisnojima Nov 4, 2019

Contributor

const {conversationIDKey} = action.payload

@mmaxim mmaxim merged commit 6163055 into master Nov 4, 2019
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@mmaxim mmaxim deleted the mike/HOTPOT-1200-2 branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.