Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an empty file to fix windows builds #20768

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@xgess
Copy link
Contributor

xgess commented Nov 4, 2019

when heat runs as part of our windows build process, it harvests all the files and folders it eventually needs to delete as part of the cleanup. it turns out, it doesn't like it when directories only have other directories in them (i.e. it does not know how to mark the parent folder for deletion because it doesn't look like anything is in it).
adding this empty file makes it behave correctly. i couldn't find a more elegant way to do this directly in heat (e.g. as another argument to pass).

@xgess xgess requested a review from mmaxim Nov 4, 2019
@mmaxim
mmaxim approved these changes Nov 4, 2019
Copy link
Contributor

mmaxim left a comment

Incredible, nice find!

@xgess xgess merged commit 09dd879 into master Nov 4, 2019
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@xgess xgess deleted the xgess/buildin-windows branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.