Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate maxCmdLength on prop change #20776

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@hyperobject
Copy link
Contributor

hyperobject commented Nov 4, 2019

This PR fixes some flakiness with navigating bot command suggestions with a keyboard by making the maxCmdLength recalculation happen every time the bot/command suggestion props change. Before, this was only taking place when the conversation ID changed.

previously only recalculated on new conversation - now looks at actual arrays
@hyperobject hyperobject requested review from mmaxim and keybase/react-hackers Nov 4, 2019
@mmaxim
mmaxim approved these changes Nov 4, 2019
@hyperobject hyperobject merged commit be44622 into master Nov 4, 2019
2 checks passed
2 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@hyperobject hyperobject deleted the cori/HOTPOT-1210/max-command-length branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.